[codex] Structure ACP schema generator errors#3362
Merged
juliusmarminge merged 4 commits intoJun 20, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
vouch:trusted
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
Contributor
ApprovabilityVerdict: Approved This PR refactors error handling in a code generation script by converting unstructured errors into typed Effect error classes. The changes are mechanical, don't alter the core logic flow, and include comprehensive tests for the new error structures. You can customize Macroscope's approvability policy. Learn more. |
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge
force-pushed
the
codex/acp-generator-errors
branch
from
15152d6 to
162cbae
Compare
juliusmarminge
changed the base branch from
main
to
codex/redact-dpop-request-target
macroscopeapp
Bot
dismissed
their stale review
Dismissing prior approval to re-evaluate 162cbae
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Schema errors thrown not yielded
- Converted collectSchemaEntries from a plain function using throw to an Effect.fn generator using yield*, so AcpGeneratorSchemaValueDeclarationMissingError and AcpGeneratorSchemaNameParseError become typed failures instead of defects.
Or push these changes by commenting:
@cursor push d506182388
Preview (d506182388)
diff --git a/packages/effect-acp/scripts/generate.ts b/packages/effect-acp/scripts/generate.ts
--- a/packages/effect-acp/scripts/generate.ts
+++ b/packages/effect-acp/scripts/generate.ts
@@ -313,9 +313,7 @@
yield* fs.writeFileString(metaOutputPath, metaOutput);
});
-function collectSchemaEntries(
- chunk: string,
-): ReadonlyArray<{ readonly name: string; readonly code: string }> {
+const collectSchemaEntries = Effect.fn("collectSchemaEntries")(function* (chunk: string) {
const lines = chunk
.split("\n")
.map((line) => line.trim())
@@ -330,14 +328,14 @@
const constLine = lines[index + 1];
if (!constLine?.startsWith("export const ")) {
- throw new AcpGeneratorSchemaValueDeclarationMissingError({
+ return yield* new AcpGeneratorSchemaValueDeclarationMissingError({
typeDeclaration: typeLine,
});
}
const match = /^export type ([A-Za-z0-9_]+)/.exec(typeLine);
if (!match?.[1]) {
- throw new AcpGeneratorSchemaNameParseError({ typeDeclaration: typeLine });
+ return yield* new AcpGeneratorSchemaNameParseError({ typeDeclaration: typeLine });
}
entries.push({
@@ -348,7 +346,7 @@
}
return entries;
-}
+});
function normalizeNullableTypes(value: Schema.Json): Schema.Json {
if (Array.isArray(value)) {
@@ -431,7 +429,7 @@
const output = generator.generate("openapi-3.1", normalizedDefinitions as never, false).trim();
if (output.length > 0) {
- for (const entry of collectSchemaEntries(output)) {
+ for (const entry of yield* collectSchemaEntries(output)) {
if (!generatedEntries.has(entry.name)) {
generatedEntries.set(entry.name, entry.code);
}You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 162cbae. Configure here.
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge
merged commit d92c31b
into
codex/redact-dpop-request-target
16 checks passed
juliusmarminge
added a commit
that referenced
this pull request
Jun 20, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge
added a commit
that referenced
this pull request
Jun 20, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge
added a commit
that referenced
this pull request
Jun 20, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge
added a commit
that referenced
this pull request
Jun 20, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge
added a commit
that referenced
this pull request
Jun 20, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge
added a commit
that referenced
this pull request
Jun 20, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge
added a commit
that referenced
this pull request
Jun 21, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge
added a commit
that referenced
this pull request
Jun 21, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge
added a commit
that referenced
this pull request
Jun 21, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
juliusmarminge
added a commit
that referenced
this pull request
Jun 21, 2026
Co-authored-by: codex <codex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
vp test packages/effect-acp/scripts/generate.test.ts --no-cachevp check(passes with pre-existing warnings)vp run typecheckvpr typecheckOverlap audit
No current open PR touches either changed path, including previous filenames.
Note
Low Risk
Changes are confined to the dev-time schema generator script and its tests; success paths are unchanged aside from safer error shapes and download cleanup ordering.
Overview
Replaces the generic
GenerateCommandErrorin the ACP schema generator with EffectSchema.TaggedErrorclasses for download (HTTP vs filesystem), upstream JSON decode,bun oxfmtformatting, and malformed generated schema lines.Download-related failures attach redacted URL context via
getUrlDiagnosticsfrom@t3tools/shared(length, protocol, hostname only—no full URL, credentials, or query in errors or messages). Underlying HTTP, FS, decode, and process failures are kept incausefields with path, stage, and command metadata where useful.downloadSchemasnow registers the temp-file cleanup finalizer before starting downloads so partial failures still remove downloaded assets. Several pipeline steps are exported and covered by a newgenerate.test.tssuite. The CLI entrypoint is gated withimport.meta.mainso importing the script no longer runs the command.Reviewed by Cursor Bugbot for commit a559447. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Structure ACP schema generator errors with tagged error types and safe URL diagnostics
TaggedErrorclasses for each failure stage: HTTP download, filesystem write, document decode, formatter process/exit, and schema entry parsing.decodeUpstreamSchemaDocument,decodeMetaDocument,formatGeneratedFiles, andcollectSchemaEntriesinto exported Effect functions with structured failure types.if (import.meta.main)guard so importing the module no longer auto-runs the generate command.collectSchemaEntriesis now an Effect and callers must bind it;generateSchemasnow propagates typed errors instead ofGenerateCommandError.Macroscope summarized a559447.